Re: [PATCH 1/1] block: return BLK_STS_NOTSUPP if operation is not supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 27, 2020 at 12:11:19PM -0700, Ritika Srivastava wrote:
> Hence block layer issues write zeroes in blkdev_issue_zeroout()
> 
> In response, the storage returns the following SCSI error
> Sense Key : Illegal Request [current]
> Add. Sense: Invalid command operation code
> 
> Once this error is received, the write zero capability of the device is disabled and write_zeroes_max_bytes is set to 0.
> DM device queue limits are also set to 0 and device-mapper fails the path.
> To avoid this, if BLK_STS_NOTSUPP could be returned, then device-mapper would not fail the paths.
> 
> Once the write zero capability has been disabled, blk-lib issues zeroes via __blkdev_issue_zero_pages().
> 
> Please let me know if I missed something.

Oh, the stupid SCSI runtime detection case again.  Can you please
document this in a comment?

Also please switch blk_cloned_rq_check_limits to just return the
blk_status_t directly.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux