On Wed 22-07-20 11:13:28, Paolo Valente wrote: > > a) I don't think adding these samples to statistics helps in any way (you > > cannot improve the prediction power of the statistics by including in it > > some samples that are not directly related to the thing you try to > > predict). And think time is used to predict the answer to the question: If > > bfq queue becomes idle, how long will it take for new request to arrive? So > > second and further requests are simply irrelevant. > > > > Yes, you are super right in theory. > > Unfortunately this may not mean that your patch will do only good, for > the concerns in my previous email. > > So, here is a proposal to move forward: > 1) I test your patch on my typical set of > latency/guaranteed-bandwidth/total-throughput benchmarks > 2) You test your patch on a significant set of benchmarks in mmtests > > What do you think? Sure, I will queue runs for the patches with mmtests :). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR