On Tue, Jul 21, 2020 at 02:49:06AM +0000, Damien Le Moal wrote: > On 2020/07/20 22:18, Vaibhav Gupta wrote: > > On Mon, Jul 20, 2020 at 12:52:14PM +0000, Damien Le Moal wrote: > >> On 2020/07/17 17:10, Vaibhav Gupta wrote: > >>> Change function parameter in both .suspend() and .resume() to > >>> "struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable. > >>> > >>> Compile-tested only. > >> > >> I do not think this belongs into the commit message. This was mentioned in the > >> cover letter. > >> > > The messages in cover letter and commit message are bit similar. But the commit > > message has patch specific changes mentioned in it. > > My point was about the "compile-tested only" mention in the commit message. That > should be mentioned in the cover letter only. The goal of the patch review > process is also to get these patches tested by others if you do not have access > to the hardware. That is fine, and I can test for the skd driver. But a patch > mentioning that it is untested cannot be applied, for obvious reasons :) > > So I only requested that you remove the "compiled tested only" note. The commit > message could be simpler too, see followup comment. > Oh okay. Thanks for clarification and pointing this out :) . From now on, I will put "Compile-tested only." message only in cover letters. Thanks. --Vaibhav Gupta > > > -- > Damien Le Moal > Western Digital Research
