On 7/1/20 6:49 PM, Chaitanya Kulkarni wrote:
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index 907c6858aec0..3f5ff75fcb3d 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -1868,11 +1868,23 @@ static int null_add_dev(struct nullb_device *dev)
> return rv;
> }
>
> +static void null_delete_nullb_list(void)
> +{
> + struct nullb_device *dev;
> + struct nullb *nullb;
> +
> + while (!list_empty(&nullb_list)) {
> + nullb = list_entry(nullb_list.next, struct nullb, list);
> + dev = nullb->dev;
> + null_del_dev(nullb);
> + null_free_dev(dev);
> + }
> +}
Since we're making the cleanup anyway, this should use list_first_entry()
--
Jens Axboe
