Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
Date: Wed, 1 Jul 2020 04:38:31 +0000
Accept-language: en-US
Cc: "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "jack@xxxxxxxx" <jack@xxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "sagi@xxxxxxxxxxx" <sagi@xxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "rostedt@xxxxxxxxxxx" <rostedt@xxxxxxxxxxx>, "snitzer@xxxxxxxxxx" <snitzer@xxxxxxxxxx>, "agk@xxxxxxxxxx" <agk@xxxxxxxxxx>, "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>, "paolo.valente@xxxxxxxxxx" <paolo.valente@xxxxxxxxxx>, "ming.lei@xxxxxxxxxx" <ming.lei@xxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>, "fangguoju@xxxxxxxxx" <fangguoju@xxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>
References: <20200629234314.10509-1-chaitanya.kulkarni@wdc.com> <20200629234314.10509-10-chaitanya.kulkarni@wdc.com> <20200630051247.GF27033@lst.de>
Wdcipoutbound: EOP-TRUE

On 6/29/20 10:12 PM, Christoph Hellwig wrote:
>> +extern void blk_fill_rwbs(char *rwbs, unsigned int op);
> You might want to drop the extern while you're at it.
> 

Good point.

References:
- [PATCH 00/10] block: blktrace framework cleanup
  - From: Chaitanya Kulkarni
- [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
  - From: Chaitanya Kulkarni
- Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
Next by Date: Re: [PATCH 10/11] block: use block_bio class for getrq and sleeprq
Previous by thread: Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
Next by thread: [PATCH 10/11] block: use block_bio class for getrq and sleeprq
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]