Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()

[Ming Lei <tom.leiming@xxxxxxxxx>]

On Mon, Apr 27, 2020 at 8:44 PM Hou Tao <houtao1@xxxxxxxxxx> wrote:
>
> And use rq directly.
>
> Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx>
> ---
>  block/blk-mq-debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index b3f2ba483992..7a79db81a63f 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>         const struct show_busy_params *params = data;
>
>         if (rq->mq_hctx == params->hctx)
> -               __blk_mq_debugfs_rq_show(params->m,
> -                                        list_entry_rq(&rq->queuelist));
> +               __blk_mq_debugfs_rq_show(params->m, rq);

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>


-- 
Ming Lei