On Mon, Jun 29, 2020 at 04:43:04PM -0700, Chaitanya Kulkarni wrote: > This patch removes the extra variables from the trace events and > overall kernel blktrace framework. The removed members can easily be > extracted from the remaining argument which reduces the code > significantly and allows us to optimize the several tracepoints like > the next patch in the series. The subject sounds a litle strange, I'd rather say: "block: remove superflous arguments from tracepoints" The actual changes look good to me. > + trace_block_rq_insert(rq); > } > > spin_lock(&ctx->lock); > @@ -2111,7 +2111,7 @@ blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) > goto queue_exit; > } > > - trace_block_getrq(q, bio, bio->bi_opf); > + trace_block_getrq(bio, bio->bi_opf); But now that you remove more than the q argument in some spots you might remove the op one here as well. Or limit the first patch to just the queue argument..
