On Tue, Jun 30, 2020 at 10:23:54AM +0800, Ming Lei wrote: > blk_mq_get_driver_tag() is only used by blk-mq.c and is supposed to > stay in blk-mq.c, so move it and preparing for cleanup code of > get/put driver tag. > > Meantime hctx_may_queue() is moved to header file and it is fine > since it is defined as inline always. hctx_may_queue looks pretty big for an inline function to start with. But except for that this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>