On 2020-06-23 15:03, Luis Chamberlain wrote: > +/** > + * struct request_queue - block device driver request queue Since request queues are used as a communication channel between the block layer core and block drivers and since the block layer core creates request queues, I propose to leave out the word "driver". > + * @debugfs_mutex: used to protect access to the @debugfs_dir > + * @blk_trace: used by blktrace to keep track of setup / tracing > + * @debugfs_dir: directory created to place debugfs information. This is always > + * created for make_request and request-based block drivers upon > + * initialization. blktrace requires for this directory to be created, > + * and so it will be created on demand if its block driver type does not > + * create it opon initialization. > + * > + * The request_queue is used to manage incoming block layer device driver > + * requests. We have three main type of block driver types which end up making > + * use of the request_queue: "incoming" is correct from the perspective of the block driver but not from the perspective of the block layer core. How about describing request queues as a communication channel between the block layer core and block drivers? Thanks, Bart.
