Re: [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kanchan Joshi <joshi.k@xxxxxxxxxxx>
Subject: Re: [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 27 Jun 2020 07:51:04 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, axboe@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, bcrl@xxxxxxxxx, asml.silence@xxxxxxxxx, Damien.LeMoal@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, mb@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-aio@xxxxxxxxx, io-uring@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, selvakuma.s1@xxxxxxxxxxx, nj.shetty@xxxxxxxxxxx, javier.gonz@xxxxxxxxxxx, Arnav Dawn <a.dawn@xxxxxxxxxxx>
In-reply-to: <20200626211514.GA24762@test-zns>
References: <1593105349-19270-1-git-send-email-joshi.k@samsung.com> <CGME20200625171834epcas5p226a24dfcb84cfa83fe29a2bd17795d85@epcas5p2.samsung.com> <1593105349-19270-2-git-send-email-joshi.k@samsung.com> <20200626085846.GA24962@infradead.org> <20200626211514.GA24762@test-zns>

On Sat, Jun 27, 2020 at 02:45:14AM +0530, Kanchan Joshi wrote:
> For block IO path (which is the scope of this patchset) there is no
> probelm in using RWF_APPEND for zone-append, because it does not do
> anything for block device. We can use that, avoiding introduction of
> RWF_ZONE_APPEND in user-space.

No, you are not just touching the block I/O path.  This is all over the
general file code, and all RWF_* flag are about file I/O.

References:
- [PATCH v2 0/2] zone-append support in io-uring and aio
  - From: Kanchan Joshi
- [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path
  - From: Kanchan Joshi
- Re: [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path
  - From: Christoph Hellwig
- Re: [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path
  - From: Kanchan Joshi

Prev by Date: Re: [PATCH v2 0/2] zone-append support in io-uring and aio
Next by Date: [PATCH 06/14] block: move the bio cgroup associatation helpers to blk-cgroup.c
Previous by thread: Re: [PATCH v2 1/2] fs,block: Introduce RWF_ZONE_APPEND and handling in direct IO path
Next by thread: [PATCH v2 2/2] io_uring: add support for zone-append
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]