On Tue, Jun 23, 2020 at 01:53:47AM -0700, Sagi Grimberg wrote:
>> if (ns->lba_shift == 0)
>> ns->lba_shift = 9;
>> + switch (ns->head->ids.csi) {
>> + case NVME_CSI_NVM:
>> + break;
>> + default:
>> + dev_warn(ctrl->device, "unknown csi:%d ns:%d\n",
>> + ns->head->ids.csi, ns->head->ns_id);
>> + return -ENODEV;
>> + }
>
> Not sure we need a switch-case statement for a single case target...
I think a switch makes inherent sense when there is an identifier that
can have multiple values, even if there only is one for now.
