On Wed, Jun 24, 2020 at 03:54:05PM -0700, Sagi Grimberg wrote: > The code needs to be: > -- > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 2afed32d3892..3e84ab6c2bd3 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1130,7 +1130,7 @@ static int nvme_identify_ns_descs(struct nvme_ctrl > *ctrl, unsigned nsid, > * Don't treat an error as fatal, as we potentially already > * have a NGUID or EUI-64. > */ > - if (status > 0 && !(status & NVME_SC_DNR)) > + if (status > 0 && (status & NVME_SC_DNR)) > status = 0; > goto free_data; > } > -- Aha, I was assuming the code was the way you wanted it, hence my confusion :) The above makes sense walking through different scenarios. I needed to reconcile this in order to understand how we'll address it with Nikla's patch that start this conversation.
