Re: [PATCH] null_blk: Move the null_blk source files into a subdirectory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/21/20 2:42 PM, Bart Van Assche wrote:
> Since the number of source files of the null_blk driver keeps growing,
> move these source files into a new subdirectory.
> 
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Dongli Zhang <dongli.zhang@xxxxxxxxxx>
> Cc: Damien Le Moal <damien.lemoal@xxxxxxx>
> Cc: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> Cc: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
>  drivers/block/Kconfig                         | 8 +-------
>  drivers/block/Makefile                        | 7 +------
>  drivers/block/null_blk/Kconfig                | 9 +++++++++
>  drivers/block/null_blk/Makefile               | 8 ++++++++
>  drivers/block/{ => null_blk}/null_blk.h       | 0
>  drivers/block/{ => null_blk}/null_blk_main.c  | 0
>  drivers/block/{ => null_blk}/null_blk_trace.c | 0
>  drivers/block/{ => null_blk}/null_blk_trace.h | 0
>  drivers/block/{ => null_blk}/null_blk_zoned.c | 0
>  9 files changed, 19 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/block/null_blk/Kconfig
>  create mode 100644 drivers/block/null_blk/Makefile
>  rename drivers/block/{ => null_blk}/null_blk.h (100%)
>  rename drivers/block/{ => null_blk}/null_blk_main.c (100%)
>  rename drivers/block/{ => null_blk}/null_blk_trace.c (100%)
>  rename drivers/block/{ => null_blk}/null_blk_trace.h (100%)
>  rename drivers/block/{ => null_blk}/null_blk_zoned.c (100%)

I'm all for this since, but why not name them null_blk/main.c etc?  A
bit annoying/redundant to have them be drivers/block/null_blk/null_main.c
and so forth.

Probably have null_blk.h be the exception.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux