On 18/06/2020 16:54, Keith Busch wrote: > diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h > index a84f71459caa..58428e3a590e 100644 > --- a/drivers/nvme/host/nvme.h > +++ b/drivers/nvme/host/nvme.h > @@ -191,6 +191,13 @@ struct nvme_fault_inject { > #endif > }; > > + > +struct nvme_cel { > + struct list_head entry; > + struct nvme_effects_log log; > + u8 csi; > +}; > + Nit this adds a double newline Otherwise: Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>