On Wed, Apr 22, 2020 at 04:03:17PM +0300, Andy Shevchenko wrote: > There is a specific API to treat raw data as UUID, i.e. import_uuid(). > Use it instead of uuid_copy() with explicit casting. Any comment on this? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > block/partitions/ldm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c > index 6fdfcb40c537b..d333786b5c7eb 100644 > --- a/block/partitions/ldm.c > +++ b/block/partitions/ldm.c > @@ -910,7 +910,7 @@ static bool ldm_parse_dsk4 (const u8 *buffer, int buflen, struct vblk *vb) > return false; > > disk = &vb->vblk.disk; > - uuid_copy(&disk->disk_id, (uuid_t *)(buffer + 0x18 + r_name)); > + import_uuid(&disk->disk_id, buffer + 0x18 + r_name); > return true; > } > > -- > 2.26.1 > -- With Best Regards, Andy Shevchenko