On Tue, Jun 16, 2020 at 10:01:35AM -0700, Keith Busch wrote:
> On Tue, Jun 16, 2020 at 11:58:59AM -0400, Martin K. Petersen wrote:
> > > @@ -1113,8 +1126,9 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,
> > > status = nvme_submit_sync_cmd(ctrl->admin_q, &c, data,
> > > NVME_IDENTIFY_DATA_SIZE);
> > > if (status) {
> > > - dev_warn(ctrl->device,
> > > - "Identify Descriptors failed (%d)\n", status);
> > > + if (ctrl->vs >= NVME_VS(1, 3, 0))
> > > + dev_warn(ctrl->device,
> > > + "Identify Descriptors failed (%d)\n", status);
> >
> > Not a biggie but maybe this should be a separate patch?
>
> Actually I think we can just get rid of this check before the warning.
> We only call this function if the version is >= 1.3 or if multi-css was
> selected. Both of those require this identification be supported.
I agree, since implementing/supporting multiple command sets also requires
you to implement the Namespace Identification Descriptor list command,
this command shouldn't fail even if a base spec < 1.3.0 was used,
so the best thing is probably just to drop this change.
Kind regards,
Niklas
