On Tue, Jun 16, 2020 at 12:33:15PM +0200, Javier González wrote:
> On 16.06.2020 08:34, Keith Busch wrote:
> > From: Niklas Cassel <niklas.cassel@xxxxxxx>
> >
> > Implements support for the I/O Command Sets command set. The command set
> > introduces a method to enumerate multiple command sets per namespace. If
> > the command set is exposed, this method for enumeration will be used
> > instead of the traditional method that uses the CC.CSS register command
> > set register for command set identification.
> >
> > For namespaces where the Command Set Identifier is not supported or
> > recognized, the specific namespace will not be created.
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> > ---
(snip)
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> > index 5ce51ab4c50e..f8b5b8d7fc7e 100644
> > --- a/include/linux/nvme.h
> > +++ b/include/linux/nvme.h
> > @@ -134,6 +134,7 @@ enum {
> > #define NVME_CAP_NSSRC(cap) (((cap) >> 36) & 0x1)
> > #define NVME_CAP_MPSMIN(cap) (((cap) >> 48) & 0xf)
> > #define NVME_CAP_MPSMAX(cap) (((cap) >> 52) & 0xf)
> > +#define NVME_CAP_CSS(cap) (((cap) >> 37) & 0xff)
>
> Small niptick: maybe move this under NVME_CAP_NSSRC to keep order?
Makes sense.
Kind regards,
Niklas
