Subject: Re: [PATCH] drivers\block: Use kobj_to_dev() API>On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote:
>> Use kobj_to_dev() API instead of container_of().
>>
>> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
>> ---
>> drivers/block/virtio_blk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> mode change 100644 => 100755 drivers/block/virtio_blk.c
>
>
>Subject should probably use "/". Besides that - trivial tree?
Sorry, I will modify subject using "/". But what do you mean about trivial tree?
>
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 9d21bf0..c808405
>> --- a/drivers/block/virtio_blk.c
>> +++ b/drivers/block/virtio_blk.c
>> @@ -630,7 +630,7 @@ static struct attribute *virtblk_attrs[] = {
>> static umode_t virtblk_attrs_are_visible(struct kobject *kobj,
>> struct attribute *a, int n)
>> {
>> - struct device *dev = container_of(kobj, struct device, kobj);
>> + struct device *dev = kobj_to_dev(kobj);
>> struct gendisk *disk = dev_to_disk(dev);
>> struct virtio_blk *vblk = disk->private_data;
>> struct virtio_device *vdev = vblk->vdev;
>> --
>> 2.7.4
>
