Re: [PATCH v6 3/6] block: revert back to synchronous request_queue removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>, axboe@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, mingo@xxxxxxxxxx, jack@xxxxxxx, ming.lei@xxxxxxxxxx, nstange@xxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v6 3/6] block: revert back to synchronous request_queue removal
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 12 Jun 2020 18:53:40 -0700
Cc: mhocko@xxxxxxxx, yukuai3@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, jejb@xxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Omar Sandoval <osandov@xxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <20200608170127.20419-4-mcgrof@kernel.org>
References: <20200608170127.20419-1-mcgrof@kernel.org> <20200608170127.20419-4-mcgrof@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 2020-06-08 10:01, Luis Chamberlain wrote:
> + * Drivers exist which depend on the release of the request_queue to be
> + * synchronous, it should not be deferred.

This sounds mysterious. Which drivers? Why do these depend on this
function being synchronous? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

Follow-Ups:
- Re: [PATCH v6 3/6] block: revert back to synchronous request_queue removal
  - From: Luis Chamberlain

References:
- [PATCH v6 0/8] block: fix blktrace debugfs use after free
  - From: Luis Chamberlain
- [PATCH v6 3/6] block: revert back to synchronous request_queue removal
  - From: Luis Chamberlain

Prev by Date: Re: [PATCH v2] blktrace: put bounds on BLKTRACESETUP buf_size and buf_nr
Next by Date: Re: [PATCH v6 4/6] blktrace: annotate required lock on do_blk_trace_setup()
Previous by thread: [PATCH v6 3/6] block: revert back to synchronous request_queue removal
Next by thread: Re: [PATCH v6 3/6] block: revert back to synchronous request_queue removal
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]