On Fri, Jun 05, 2020 at 04:42:36PM +0200, Jan Kara wrote: > On Fri 05-06-20 12:43:54, Dan Carpenter wrote: > > I wonder if maybe the best fix is to re-add the "if (!res) " check back > > to blkdev_get(). > > Well, it won't be that simple since we need to call bd_abort_claiming() > under bdev->bd_mutex. And the fact that __blkdev_get() frees the reference > you pass to it is somewhat subtle and surprising so I think we are better > off getting rid of that. Fair enough. Jason Yan sent a v3 of this patch that frees "whole". I've looked it over pretty close and I think it's probably correct. (not that my opinion should count for much because I don't know this code very well at all). regards, dan carpenter
