On Tue 02-06-20 03:10:42, Chaitanya Kulkarni wrote: > On 6/1/20 7:27 PM, Bart Van Assche wrote: > > On 2020-06-01 18:32, Chaitanya Kulkarni wrote: > >> Since request queue's blk_trace member is been markds as __rcu, > >> replace xchg() and cmdxchg() calls with appropriate rcu API. > >> This removes the sparse warnings. > > This patch looks like a subset of a patch that was posted a few days ago > > by Jan Kara? See also > > https://lore.kernel.org/linux-block/20200528092910.11118-1-jack@xxxxxxx/. > > > > Bart. > > > > Thanks for pointing out. I think my patch maintains the goto labels and > keeps the original code flow with two calls as mentioned in the patch > description. Maybe we can merge both patches keeping Jan as an Original > author since his patch was sent first ? Yes, my patch also removes the unnecessary atomic operations besides fixing the sparse warnings. I'll rebase it on top of Luis' patches [1] which conflict with it and resend it. Honza [1] https://lore.kernel.org/linux-block/20200516031956.2605-1-mcgrof@xxxxxxxxxx/ -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
