On 2020-05-29 09:34, Coly Li wrote: > +static inline unsigned int bio_aligned_discard_max_sectors( > + struct request_queue *q) > +{ > + return round_down(UINT_MAX, > + (q->limits.max_discard_sectors << SECTOR_SHIFT)) > + >> SECTOR_SHIFT; > +} max_discard_sectors has been declared as an unsigned int. Can the shift left operation overflow? Thanks, Bart.