On Fri, May 29, 2020 at 11:39:46AM +0800, Ming Lei wrote: > On Fri, May 29, 2020 at 4:19 AM Alan Adamson <alan.adamson@xxxxxxxxxx> wrote: > That said NVMe's > error handling becomes better after applying the patchs of '[PATCH > 0/3] blk-mq/nvme: improve > nvme-pci reset handler'. I think that's a bit debatable. Alan is synthesizing a truly broken controller. The current code will abandon this controller after about 30 seconds. Your series will reset that broken controller indefinitely. Which of those options is better? I think degrading to an admin-only mode at some point would be preferable.