On Fri, May 15, 2020 at 3:53 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 5/15/20 4:29 AM, Danil Kipnis wrote: > > Hi Jens, > > > > we've fixed the kbuild cross-compile problem identified for our > > patches for 5.7-rc4. The block part has been reviewed by Bart van > > Assche (thanks a lot Bart), we also replaced idr by xarray there as > > Jason suggested. You planned to queue us > > for 5.7: https://www.spinics.net/lists/linux-rdma/msg88472.html. Could > > you please give Jason an OK to take this through the rdma tree, see > > https://www.spinics.net/lists/linux-rdma/msg91400.html? > > My main worry isn't the current state of it, it's more how it's going > to be handled going forward. If you're definitely going to maintain > the upstream code in a suitable fashion, and not maintain an on-the-side > version that you push to clients, then I'm fine with it going upstream > and you can add my acked-by to the block part of the series. > > But maintaining the upstream version as the canonical version is key > here. > > -- > Jens Axboe Hi Jens, Thank you very much for your reply. As mentioned in the past, we are committed to maintaining the code once it's in upstream, we tried hard to make sure the upstream version is compatible with our in house version, so we can switch to the upstream version in the future, the main difference is the driver name/sysfs, we have to adapt other in house tools which use the old "ibnbd/ibtrs" names to new "rnbd/rtrs" names, it will take a bit time, but it will happen for sure. And we will follow the upstream process to push RNBD/RTRS further. Regards! Jack Wang
