On Wed, May 13, 2020 at 11:47:56AM +0800, Ming Lei wrote: > Now request is thought as in-flight only when its state is updated as > MQ_RQ_IN_FLIGHT, which is done by driver via blk_mq_start_request(). This should probably mention who considers it it in flight. > Actually from blk-mq's view, one rq can be thought as in-flight > after its tag is >= 0. > Add one new function of blk_mq_all_tag_iter so that we can iterate > every in-flight request, and this way is more flexible since caller > can decide to handle request according to rq's state. Maybe I'd reword the whole commit log as: "Add a new blk_mq_all_tag_iter that iterates all requets which have a tag assigned to them. This is more flexible than the existing iterator iterator as it allows the caller to check the request state and act upon it." Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
