On Wed 06-05-20 15:50:30, Paolo Valente wrote: > Does this fix make process names (with PIDS) be shown too in bfq log messages? No, I didn't change how that's handled. Also AFAICS the kernel does not add PID information to BLK_TN_MESSAGE events (which is how bfq log messages are passed) so blkparse has nothing to display even if it wanted. So poor man's solution is to derive pid from the BFQ queue name and then lookup process name from some other event. Nicer solution would be to modify blktrace handling in the kernel to add PID information to such events as well so we get similar info as when using tracing infrastructure directly. Honza > > Il giorno 6 mag 2020, alle ore 15:39, Jan Kara <jack@xxxxxxx> ha scritto: > > > > I was investigating a performance issue with BFQ IO scheduler and I was > > pondering why I'm not seeing informational messages from BFQ. After quite > > some debugging I have found out that commit 35fe6d763229 "block: use > > standard blktrace API to output cgroup info for debug notes" broke standard > > blktrace API - namely the informational messages logged by bfq_log_bfqq() > > are no longer displayed by blkparse(8) tool. This is because these messages > > have now __BLK_TA_CGROUP bit set and that breaks flags checking in > > blkparse(1) and iowatcher(1). This series fixes both tools to be able to > > cope with events with __BLK_TA_CGROUP flag set. > > > > Honza > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
