On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote: > > Err, that function is static and has two callers. > > Yes but that is to make it easier to look for who is creating the > debugfs_dir for either the request_queue or partition. I'll export > blk_debugfs_root and we'll open code all this. No, please not. exported variables are usually a bad idea. Just skip the somewhat pointless trivial static function.