On Tue, Apr 28, 2020 at 01:27:54PM +0200, Christoph Hellwig wrote: > Instead of a convoluted chain just check for REQ_OP_READ directly, > and keep all the memory stall code together in a single unlikely > branch. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Hm, I have to say I don't prefer one version over the other here. Keeping the the stall annotation code more compact is nice, but the duplicate generic_make_request() seems to suggest that the requests themselves are also somehow made differently, when it's really just the annotation that's conditional. That said, the patch looks correct to me. Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx>
