> +static int > +loop_validate_size(loff_t size) > +{ > + if ((loff_t)(sector_t)size != size) > + return -EFBIG; > + else > + return 0; Nit: no real need for an else after a return. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> +static int > +loop_validate_size(loff_t size) > +{ > + if ((loff_t)(sector_t)size != size) > + return -EFBIG; > + else > + return 0; Nit: no real need for an else after a return. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>