On Sat, Apr 18, 2020 at 11:09:22AM +0800, Ming Lei wrote: > Flush requests aren't same with normal FS request: > > 1) on dedicated per-hctx flush rq is pre-allocated for sending flush request > > 2) flush requests are issued to hardware via one machinary so that flush merge > can be applied > > We can't simply re-submit flush rqs via blk_steal_bios(), so add > blk_end_flush_machinery to collect flush requests which needs to > be resubmitted: > > - if one flush command without DATA is enough, send one flush, complete this > kind of requests > > - otherwise, add the request into a list and let caller re-submit it. The code looks sensible: Reviewed-by: Christoph Hellwig <hch@xxxxxx>