On Mon, Apr 20, 2020 at 11:34:11AM +0100, John Garry wrote:
>> EXPORT_SYMBOL(blk_mq_tagset_busy_iter);
>> diff --git a/block/blk-mq-tag.h b/block/blk-mq-tag.h
>> index 2b8321efb682..fdf095d513e5 100644
>> --- a/block/blk-mq-tag.h
>> +++ b/block/blk-mq-tag.h
>> @@ -21,6 +21,7 @@ struct blk_mq_tags {
>> struct list_head page_list;
>> };
>> +typedef bool (busy_rq_iter_fn)(struct request *, void *, bool);
>> extern struct blk_mq_tags *blk_mq_init_tags(unsigned int nr_tags,
>> unsigned int reserved_tags, int node, int alloc_policy);
>> extern void blk_mq_free_tags(struct blk_mq_tags *tags);
>> @@ -34,6 +35,9 @@ extern int blk_mq_tag_update_depth(struct blk_mq_hw_ctx *hctx,
>> extern void blk_mq_tag_wakeup_all(struct blk_mq_tags *tags, bool);
>> void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_iter_fn *fn,
>> void *priv);
>> +void blk_mq_all_tag_busy_iter(struct blk_mq_tags *tags,
>> + busy_tag_iter_fn *fn, busy_rq_iter_fn *busy_rq_fn,
>> + void *priv);
>
> Could you please pay attention to alignment of the arguments and the
> opening brace? This patchset fails that in many places.
Mings patch use the perfectly fine two tab alignment, which in many
ways is much easier to deal with than the weird brace alignment.
