On Sat, Apr 18, 2020 at 08:40:20AM -0700, Bart Van Assche wrote: > > This can have a sideeffect not only bdi->dev_name will be truncated to 64 > > chars (which generally doesn't matter) but possibly also kobject name will > > be truncated in the same way. Which may have user visible effects. E.g. > > for fs/vboxsf 64 chars need not be enough. So shouldn't we rather do it the > > other way around - i.e., let device_create_vargs() create the device name > > and then copy to bdi->dev_name whatever fits? > > How about using kvasprintf() instead of vsnprintf()? That is what v1 did, see the thread in response to that on why it isn't a good idea.
