On 10/04/2020 09:10, Christoph Hellwig wrote: > -/** > - * __bio_add_pc_page - attempt to add page to passthrough bio > - * @q: the target queue > - * @bio: destination bio > - * @page: page to add > - * @len: vec entry length > - * @offset: vec entry offset > - * @same_page: return if the merge happen inside the same page > - * > - * Attempt to add a page to the bio_vec maplist. This can fail for a > - * number of reasons, such as the bio being full or target block device > - * limitations. The target block device must allow bio's up to PAGE_SIZE, > - * so it is always possible to add a single page to an empty bio. > - * > - * This should only be used by passthrough bios. > +/* > + * Add a page to a bio while respecting the hardware max_sectors, max_segment > + * and gap limitations. > */ > -static int __bio_add_pc_page(struct request_queue *q, struct bio *bio, > +static int bio_add_hw_page(struct request_queue *q, struct bio *bio, > struct page *page, unsigned int len, unsigned int offset, > - bool *same_page) > + unsigned int max_sectors, bool *same_page) Should I split that rename into a prep patch and if yes add you as the author?
