On Fri, Apr 03, 2020 at 12:27:26PM +0200, Andrzej Pietrasiewicz wrote: > > The backingq could move into this local scope. > > > > > + } else if ((!file->f_op->fallocate) || lo->lo_encrypt_key_size) { > > > > No need for the inner braces. > > > > But the actual functionality looks good to me. > > > > Would you A-b or R-b if I corrected the two small issues which you found? Sure: Reviewed-by: Christoph Hellwig <hch@xxxxxx>