On Fri, Mar 27, 2020 at 05:13:55PM +0000, Johannes Thumshirn wrote: > On 27/03/2020 18:07, Christoph Hellwig wrote: > > On Sat, Mar 28, 2020 at 01:50:11AM +0900, Johannes Thumshirn wrote: > >> +EXPORT_SYMBOL(bio_release_pages); > >> > >> static int __bio_iov_bvec_add_pages(struct bio *bio, struct iov_iter *iter) > >> { > >> @@ -1111,6 +1112,7 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) > >> bio_set_flag(bio, BIO_NO_PAGE_REF); > >> return bio->bi_vcnt ? 0 : ret; > >> } > >> +EXPORT_SYMBOL(bio_iov_iter_get_pages); > > > > EXPORT_SYMBOL_GPL, please. > > > > Sure, only for bio_iov_iter_get_pages or bio_release_pages as well? > > I couldn't find a clear pattern in block/bio.c, it's _GPL 7 times vs 28 > times without _GPL. Both. All the new internal stuff should be _GPL.