Hi Bart, > > Is the dependency on nproc because null_blk expects submit_queue <= online > > cpus? > > That's correct. I want to test with the maximum number of submit queues > allowed, hence the use of $(nproc). Ok, I'd probably add this info as comment or have it in the commit message. Just in case someone in the future wonders why nproc. > > Though why the 100? > > > > for ((i=0;i<100;i++)); do > > echo 1 >$sq > > nproc >$sq > > done > > No particular reason other than "a significant number of iterations". > > > And shouldn't be there a test for error? Ah ok. I was getting paranoid about numbers :) > All I want to test is the absence of kernel crashes. The blktests > framework already inspects dmesg for the absence of kernel crashes. So I > don't think that I have to check whether or not the quoted sysfs writes > succeed. Maybe adding this info to the commit message what this test tries to cover wouldn't hurt. Thanks, Daniel
