Re: [PATCH blktests v3 3/4] Introduce the function _configure_null_blk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-03-23 04:19, Daniel Wagner wrote:
> On Fri, Mar 20, 2020 at 03:24:12PM -0700, Bart Van Assche wrote:
>> diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
>> index a56e7a8269db..7e610a0ccbbb 100644
>> --- a/common/multipath-over-rdma
>> +++ b/common/multipath-over-rdma
>> @@ -620,18 +620,11 @@ run_fio() {
>>  configure_null_blk() {
>>  	local i
>>  
>> -	(
>> -		cd /sys/kernel/config/nullb || return $?
>> -		for i in nullb0 nullb1; do (
>> -			{ mkdir -p $i &&
>> -				  cd $i &&
>> -				  echo 0 > completion_nsec &&
>> -				  echo 512 > blocksize &&
>> -				  echo $((ramdisk_size>>20)) > size &&
>> -				  echo 1 > memory_backed &&
>> -				  echo 1 > power; } || exit $?
>> -		) done
>> -	)
>> +	for i in nullb0 nullb1; do
>> +		_configure_null_blk nullb$i completion_nsec=0 blocksize=512 \
> 
> I think this should be:
> 
> 		_configure_null_blk $i completion_nsec=0 blocksize=512 \

Good catch, will fix.

Thanks,

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux