Re: [PATCH] dm zoned: remove duplicated nr_rnd_zones increasement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/03/22 18:30, Bob Liu wrote:
> zmd->nr_rnd_zones was increased twice by mistake.
> The other place:
> 1131                 zmd->nr_useable_zones++;
> 1132                 if (dmz_is_rnd(zone)) {
> 1133                         zmd->nr_rnd_zones++;
> 					^^^
> 
> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>

Good catch ! But you need to add a Fixes tag and CC stable.

    Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
    Cc: stable@xxxxxxxxxxxxxxx

Other than that, looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>

> ---
>  drivers/md/dm-zoned-metadata.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index 516c7b6..369de15 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -1109,7 +1109,6 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
>  	switch (blkz->type) {
>  	case BLK_ZONE_TYPE_CONVENTIONAL:
>  		set_bit(DMZ_RND, &zone->flags);
> -		zmd->nr_rnd_zones++;
>  		break;
>  	case BLK_ZONE_TYPE_SEQWRITE_REQ:
>  	case BLK_ZONE_TYPE_SEQWRITE_PREF:
> 


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux