On Wed, Mar 11, 2020 at 12:10 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx> wrote: > > > > On 3/10/20 11:35 PM, Matteo Croce wrote: > > +++ b/drivers/md/raid1.c > > @@ -2129,7 +2129,7 @@ static void process_checks(struct r1bio *r1_bio) > > int vcnt; > > > > /* Fix variable parts of all bios */ > > - vcnt = (r1_bio->sectors + PAGE_SIZE / 512 - 1) >> (PAGE_SHIFT - 9); > > + vcnt = (r1_bio->sectors + PAGE_SECTORS - 1) >> (PAGE_SHIFT - 9); > > Maybe replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too. > > Thanks, > Guoqing > Wow, there are a lot of them! $ git grep -c 'PAGE_SHIFT - 9' arch/ia64/include/asm/pgtable.h:2 block/blk-settings.c:2 block/partition-generic.c:1 drivers/md/dm-table.c:1 drivers/md/raid1.c:1 drivers/md/raid10.c:1 drivers/md/raid5-cache.c:5 drivers/md/raid5.h:1 drivers/nvme/host/fc.c:1 drivers/nvme/target/loop.c:1 fs/erofs/internal.h:1 fs/ext2/dir.c:1 fs/libfs.c:1 fs/nilfs2/dir.c:1 mm/page_io.c:2 mm/swapfile.c:6 -- Matteo Croce per aspera ad upstream
