On Wed 04-03-20 12:36:13, Oleg Nesterov wrote: [...] > IOW, I mostly agree with > > - * Flush all pending signals for this kthread. > + * Flush all pending signals for this kthread. Please note that this interface > + * shouldn't be used and in fact it is DEPRECATED. > + * Existing users should be double checked because most of them are likely > + * obsolete. Kernel threads are not on the receiving end of signal delivery > + * unless they explicitly request that by allow_signal() and in that case > + * flush_signals is almost always a bug because signal should be processed > + * by kernel_dequeue_signal rather than dropping them on the floor. > > you wrote in your previous email, but "DEPRECATED" and "almost always a bug" > looks a bit too strong to me. So what would be a legit usecase to drop all signals while explicitly calling allow_signal? -- Michal Hocko SUSE Labs
