Hi Denis, On Sun, Mar 01, 2020 at 11:21:45AM +0300, Denis Efremov wrote: > Hi, > > For patches 11-16, > > I've checked the building on x86, arm. > x86 shows no difference in floppy.o binary. Thanks for double-checking. > Compilation on arm tested (make rpc_defconfig). > > I think that macro fd_outb from arm could be turned to > the static inline function, like on mips or m68k arches. However, > it's up to you if you want to keep the changes close to the > original structure. I wanted to do it as well but wondered if we should focus on limiting changes or doign an in-depth cleanup. I'll see if I find time for an extra round of per-arch cleanup, I think it doesn't cost much and is probably worth being done. > Please address the warnings and resend the patches: (...) Will do in my local patch set and I'll also CC RMK and the few other persons having touched the ARM part of the driver. > Everything else looks good to me. Thanks! Thank you! I've also found an unlocking bug in the driver, when doing ioctl(FDRESET), if a signal comes, we leave without unlocking. I'll send a separate patch for this. Regards, Willy
