On Tue, Feb 25, 2020 at 06:39:05PM +0300, Denis Efremov wrote: > On 2/25/20 6:22 PM, Denis Efremov wrote: > > As for now, I can see that only floppy.c includes fdreg.h file > > with define FDPATCHES. If it's true then #define FD_IOPORT 0x3f0 > > branch is never used and we can try to fix remaining FD_* macro > > in the next round. > > Ah, I forgot that fdregs.h is uapi. Thus, we can't simplify FDPATCHES. Yep, that's why we can't do it. I also agree with the other change of fdc->current_fdc in floppy.h, I think it's the most reasonable. And if it breaks anywhere, it will simply have uncovered new latent bugs because it will mean that it was using the wrong fdc. Willy
