On Feb 19, 2020 / 08:28, Christoph Hellwig wrote: > On Wed, Feb 19, 2020 at 01:26:32PM +0900, Shin'ichiro Kawasaki wrote: > > + /* Iterate partitions skipping the holder device at index 0 */ > > s/holder/whole/ ? Ok, 'whole device' sounds more natural. > > > +extern bool disk_has_partitions(struct gendisk *disk); > > No need for externs on function prototypes in headers. Thanks. I found that coding-style.rst says "Do not use the extern keyword with function prototypes". Will reflect to the v2 patch. -- Best Regards, Shin'ichiro Kawasaki
