On Tue, Feb 11, 2020 at 01:08:16AM +0300, Alexey Dobriyan wrote: > void blk_queue_chunk_sectors(struct request_queue *q, unsigned int chunk_sectors) > { > - BUG_ON(!is_power_of_2(chunk_sectors)); > q->limits.chunk_sectors = chunk_sectors; > } This breaks blk_max_size_offset() if the value isn't a power of 2, but I wouldn't want to replace its cheap mask with an expensive divide operation anyway. Please keep the power-of-2 requirement.