Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>, <axboe@xxxxxxxxx>, <ming.lei@xxxxxxxxxx>, <chaitanya.kulkarni@xxxxxxx>, <damien.lemoal@xxxxxxx>, <dhowells@xxxxxxxxxx>, <asml.silence@xxxxxxxxx>, <ajay.joshi@xxxxxxx>
Subject: Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
From: "yukuai (C)" <yukuai3@xxxxxxxxxx>
Date: Fri, 7 Feb 2020 15:10:01 +0800
Cc: <linux-block@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <yi.zhang@xxxxxxxxxx>, <zhangxiaoxu5@xxxxxxxxxx>, <luoshijie1@xxxxxxxxxx>
In-reply-to: <d253d904-fe37-c1cd-05f5-a02f7c5730d3@huawei.com>
References: <20200206111052.45356-1-yukuai3@huawei.com> <51b4cd75-2b19-3e4d-7ead-409c77c44b70@acm.org> <d253d904-fe37-c1cd-05f5-a02f7c5730d3@huawei.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 2020/2/7 14:02, yukuai (C) wrote:

And I do agree that commit 7b36a7189fc3 is the right
one.


My apologize that this is a mistake. Commit db6d99523560 is the one that
makes it safe to revert commit dc9edc44de6c. Because Commit db6d99523560
remove blk_exit_rl() from blkg_free().

blkg_release
  call_rcu --> can't sleep inside this
    __blkg_release
      blkg_free
        blk_exit_rl
	  blk_put_queue

References:
- [PATCH] block: revert pushing the final release of request_queue to a workqueue.
  - From: yu kuai
- Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
  - From: Bart Van Assche
- Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
  - From: yukuai (C)

Prev by Date: Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
Next by Date: Re: [PATCH v2 20/27] compat_ioctl: simplify the implementation
Previous by thread: Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
Next by thread: Re: [PATCH] block: revert pushing the final release of request_queue to a workqueue.
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]