Re: [PATCH] blk-mq: Update blk_mq_map_queue() documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-02-06 09:50, Daniel Wagner wrote:
> Commit 8ccdf4a37752 ("blk-mq: save queue mapping result into ctx
> directly") changed the last argument name from cpu to ctx but missed
> to update the documentation.
> 
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
>  block/blk-mq.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-mq.h b/block/blk-mq.h
> index eaaca8fc1c28..76921a970c32 100644
> --- a/block/blk-mq.h
> +++ b/block/blk-mq.h
> @@ -97,7 +97,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>   * blk_mq_map_queue() - map (cmd_flags,type) to hardware queue
>   * @q: request queue
>   * @flags: request command flags
> - * @cpu: cpu ctx
> + * @ctx: software queue state
>   */
>  static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>  						     unsigned int flags,

Just "software queue" instead of "software queue state" probably would
have been more clear. I think that's the name that is used elsewhere in
the block layer. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux