On Mon, Jan 06, 2020 at 12:46:26AM +0000, Singh, Balbir wrote: > On Sat, 2020-01-04 at 22:27 +0000, Chaitanya Kulkarni wrote: > > Quick question here if user executes nvme ns-rescan /dev/nvme1 > > will following code result in triggering uevent(s) for > > the namespace(s( for which there is no change in the size ? > > > > If so is that an expected behavior ? > > > > My old code had a check to see if old_capacity != new_capacity as well. > I can redo those bits if needed. > > The expected behaviour is not clear, but the functionality is not broken, user > space should be able to deal with a resize event where the previous capacity > == new capacity IMHO. I think it makes sense to not bother with a notification unless there is an actual change.