On Tue, Jan 07, 2020 at 11:01:47AM -0600, Tony Asleson wrote:
> On 1/6/20 7:23 PM, Dave Chinner wrote:
> > On Mon, Jan 06, 2020 at 07:19:07PM -0500, Sweet Tea Dorminy wrote:
> >>>>>> +
> >>>>>> if (mp && mp->m_fsname) {
> >>>>>
> >>>>> mp->m_fsname is the name of the device we use everywhere for log
> >>>>> messages, it's set up at mount time so we don't have to do runtime
> >>>>> evaulation of the device name every time we need to emit the device
> >>>>> name in a log message.
> >>>>>
> >>>>> So, if you have some sooper speshial new device naming scheme, it
> >>>>> needs to be stored into the struct xfs_mount to replace mp->m_fsname.
> >>>>
> >>>> I don't think we want to replace mp->m_fsname with the vpd 0x83 device
> >>>> identifier. This proposed change is adding a key/value structured data
> >>>> to the log message for non-ambiguous device identification over time,
> >>>> not to place the ID in the human readable portion of the message. The
> >>>> existing name is useful too, especially when it involves a partition.
> >>>
> >>> Oh, if that's all you want to do, then why is this identifier needed
> >>> in every log message?
>
> The value is we can filter all the messages by the id as they are all
> individually identifiable.
Then what you want is the *filesystem label* or *filesystem UUID*
in the *filesystem log output* to uniquely identify the *filesystem
log output* regardless of the block device identifier the kernel
assigned it's underlying disk.
By trying to use the block device as the source of a persistent
filesytem identifier, you are creating more new problems about
uniqueness than you are solving. E.g.
- there can be more than one filesystem per block device, so the
identifier needs to be, at minimum, a {dev_id, partition} tuple.
The existing bdev name (e.g. sda2) that filesystems emit contain
this information. The underlying vpd device indentifier does not.
- the filesystem on a device can change (e.g. mkfs), so an unchanged
vpd identifier does not mean we mounted the same filesystem
- raid devices are made up of multiple physical devices, so using
device information for persistent identification is problematic,
especially when devices fail and are replaced with different
hardware.
- clone a filesystem to a new device to replace a failing disk,
block device identifier changes but the filesystem doesn't.
Basically, if you need a *persistent filesystem identifier* for
your log messages, then you cannot rely on the underlying device to
provide that. Filesystems already have unique identifiers in them
that can be used for this purpose, and we have mechanisms to allow
users to configure them as well.
IOWs, you're trying to tackle this "filesystem identifier" at the
wrong layer - use the persistent filesystem identifiers to
persitently identify the filesystem across mounts, not some random
block device identifier.
> The structured data id that the patch series adds is not outputted by
> default by journalctl. Please look at cover letter in patch series for
> example filter use. You can see all the data in the journal entries by
> using journalctl -o json-pretty.
Yes, I understand that. But my comments about adding redundant
information to the log text output were directed at your suggestiong to
use dev_printk() instead of printk to achieve what you want. That
changes the log text output by prepending device specific strings to
the filesystem output.
> One can argue that we are adding a lot of data to each log message
> as the VPD data isn't trivial. This could be mitigated by hashing
> the VPD and storing the hash as the ID, but that makes it less
> user friendly. However, maybe it should be considered.
See above, I don't think the VPD information actually solves the
problem you are seeking to solve.
> >>> It does not change over the life of the filesystem, so it the
> >>> persistent identifier only needs to >>> be
> emitted to the log once at filesystem mount time. i.e. >>>
> instead of:
> >>>
> >>> [ 2.716841] XFS (dm-0): Mounting V5 Filesystem
> >>>
> >>> It just needs to be:
> >>>
> >>> [ 2.716841] XFS (dm-0): Mounting V5 Filesystem on device
> >>> <persistent dev id>
> >>>
> >>> If you need to do any sort of special "is this the right
> >>> device" checking, it needs to be done immediately at mount
> >>> time so action can be taken to shutdown the filesystem and
> >>> unmount the device immediately before further damage is
> >>> done....
> >>>
> >>> i.e. once the filesystem is mounted, you've already got a
> >>> unique and persistent identifier in the log for the life of
> >>> the filesystem (the m_fsname string), so I'm struggling to
> >>> understand exactly what problem you are trying to solve by
> >>> adding redundant information to every log message.....
>
> m_fsname is only valid for the life of the mount, not the life of
> the FS. Each and every time we reboot, remove/reattach a device
> the attachment point may change and thus the m_fsname changes too.
Well, yes, that's because m_fsname is currently aimed at identifying
the block device that the filesytem is currently mounted on. That's
the block device we *actually care about* when trying to diagnose
problems reported in the log. From that perspective, I don't want
the log output to change - it contains exactly what we need to
diagnose problems when things go wrong.
But for structured logging, using block device identifiers for the
filesystem identifier is just wrong. If you need new information,
append the UUID from the filesystem to the log message and use that
instead. i.e your original printk_emit() function should pass
mp->m_sb.sb_uuid as the post-message binary filesystem identifier,
not the block device VPD information.
If you need to convert the filesystem uuid to a block device, then
you can just go look up /dev/disk/by-uuid/ and follow the link the
filesystem uuid points to....
> > And, for the log rotation case, the filesystem log output
> > already has a unique, persistent identifier for the life of the
> > mount - the fsname ("dm-0" in the above example). We don't need
> > to add a new device identifier to the XFS log messages to solve
> > that problem because *we've already got a device identifier in
> > the log messages*.
>
> It's very useful to have an ID that persists and identifies across
> mounts. The existing id logging scheme tells you where something
> is attached, not what is attached.
Yup, that's what the filesystem labels and UUIDs provide. We've been
using them for this purpose for a long, long time.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
