On 1/4/20 6:41 PM, Ming Lei wrote:
> Commit 85a8ce62c2ea ("block: add bio_truncate to fix guard_bio_eod")
> adds bio_truncate() for handling bio EOD. However, bio_truncate()
> doesn't use the passed 'op' parameter from guard_bio_eod's callers.
>
> So bio_trunacate() may retrieve wrong 'op', and zering pages may
> not be done for READ bio.
>
> Fixes this issue by moving guard_bio_eod() after bio_set_op_attrs()
> in submit_bh_wbc() so that bio_truncate() can always retrieve correct
> op info.
>
> Meantime remove the 'op' parameter from guard_bio_eod() because it isn't
> used any more.
I'll queue this up, since the previous fix went through the block tree.
--
Jens Axboe
