On Thu, Dec 19, 2019 at 02:04:13PM -0800, Bart Van Assche wrote: > On 12/19/19 1:47 PM, Omar Sandoval wrote: > > On Fri, Dec 13, 2019 at 09:32:28AM -0500, Bart Van Assche wrote: > > > Recently a new low-level RDMA driver went upstream, namely the SoftiWARP > > > driver. That driver implements RDMA over TCP. Support has been added in the > > > SRP initiator and target drivers for iWARP. This patch series adds a test > > > for SRP over SoftiWARP. Please consider integration of this patch series in > > > the official blktests repository. > > > > > > Changes compared to v1: > > > - Only run the new test if the kernel version is at least 5.5 (the version in > > > which iWARP support was added to the SRP drivers) and if "rdma link" is > > > supported. > > > > Is there no way to detect this feature other than checking the kernel > > version? > > Hi Omar, > > The only other way I can think of to verify whether the SRP initiator and > target drivers support iWARP is by loading the SRP drivers, loading the > iWARP driver, by configuring LIO + ib_srpt and by attempting to set up a > connection. However, I assume that's way more than what a _have() test > should do? Hmm, we should probably add the ability to skip a test from test() in order to handle these cases where you need to do a bunch of setup before you know whether the test can run. For now, the kernel version check is fine.